Validate extracted Javadoc snippets during javadoc build; refresh GeneratedCN1Access (add java.time, remove impl entries) by liannacasper · Pull Request #4668 · codenameone/CodenameOne

liannacasper · 2026-03-30T11:15:13Z

Motivation

Prevent broken or hung JavaDoc generation by validating extracted javadoc snippets before running javadoc and timeboxing validation.
Update the generated CN1 access registry to match upstream API changes by removing internal implementation types and adding new public API types (notably Java 8 time classes and a UI type).

Description

Added a run_with_timeout() helper and a pre-generation step in .github/scripts/build_javadocs.sh that runs validate-extracted-javadoc-snippets.sh (if executable) with a 300-second timeout and fails the script on timeout or non-zero exit.
Kept the existing temp source staging and the javadoc invocation and added explicit messaging on validation and timeout handling.
Replaced/regenerated scripts/cn1playground/common/src/main/java/bsh/cn1/GeneratedCN1Access.java to remove com.codename1.impl.* entries, add com.codename1.ui.AbstractDialog and many java.time.* classes (including format/temporal types), and to expand/repartition the class/method/field index implementation (introduced additional fill*Index partitions such as index 11) to accommodate the new entries.
Adjusted imports and method/field indices throughout the generated registry to reflect the new/removed types and maintain indexing consistency.

Testing

No automated tests were executed for these changes.

Codex Task

…-error-dffkjz Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>

github-actions · 2026-03-30T11:25:45Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2348 total, 0 failed, 0 skipped
📊 Line coverage: 53.29% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 94 more
- ❌ android: 413 findings (High: 24, Normal: 196, Low: 193)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1085 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1286 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 410 more
- ❌ codenameone-maven-plugin: 487 findings (High: 1, Normal: 315, Low: 171)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 484 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1228 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

github-actions · 2026-03-30T11:26:11Z

Cloudflare Preview

URL: https://pr-4668-website-preview.codenameone.pages.dev
Branch: pr-4668-website-preview

Restore CN1 API registry availability in playground

8c429e9

liannacasper added the codex label Mar 30, 2026 — with ChatGPT Codex Connector

Merge branch 'master' into codex/fix-playground-component-recognition…

8e0f63a

…-error-dffkjz Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>

liannacasper merged commit c49c2b8 into master Mar 30, 2026
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate extracted Javadoc snippets during javadoc build; refresh GeneratedCN1Access (add java.time, remove impl entries)#4668

Validate extracted Javadoc snippets during javadoc build; refresh GeneratedCN1Access (add java.time, remove impl entries)#4668
liannacasper merged 2 commits intomasterfrom
codex/fix-playground-component-recognition-error-dffkjz

liannacasper commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

liannacasper commented Mar 30, 2026

Motivation

Description

Testing

Uh oh!

github-actions bot commented Mar 30, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

github-actions bot commented Mar 30, 2026

Cloudflare Preview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant